Excellent :)
Suggest simply move the prototype for _internal into the two C files that use it, so it's not even available for anyone who shouldn't have it? Kind of yucky though, it's true...
On 2013-09-08, at 7:32 PM, mmann@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51844
>
> User: mmann
> Date: 2013/09/08 12:32 PM
>
> Log:
> Couldn't quite figure out how to make the expert items in proto.c and the LUA API filterable (suggestions welcome!), but I wanted to start forcing dissectors to use the filterable expert API (nothing like compile errors to force change!). I created expert_add_info_format_internal (original expert_add_info_format) and used it as a placeholder for proto.c/LUA API until a solution is created. The "new" expert_add_info_format will be the "old" expert_add_info_format_text, and I'll slowly do the search/replace.
>
> For those with dissectors outside the source tree, please see tools/convert_expert_add_info_format.pl for help with the conversion. Please do not use expert_add_info_format_internal, as it's support time will be very short lived.
>
> Directory: /trunk/epan/
> Changes Path Action
> +2 -2 expert.c Modified
> +7 -4 expert.h Modified
> +2 -2 proto.c Modified
>
> Directory: /trunk/epan/wslua/
> Changes Path Action
> +2 -2 init_wslua.c Modified
> +1 -1 wslua_tree.c Modified
>
> ___________________________________________________________________________
> Sent via: Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe