Wireshark · Wireshark-dev: Re: [Wireshark-dev] dissect_sip_tcp_heur()

Wireshark-dev: Re: [Wireshark-dev] dissect_sip_tcp_heur()

From: Hadriel Kaplan <hadriel.kaplan@xxxxxxxxxx>

Date: Mon, 12 Aug 2013 08:49:04 -0400

On Aug 12, 2013, at 6:22 AM, Martin Kaiser <lists@xxxxxxxxx> wrote:

>> I'm not really familiar with SIP over TCP (in all my use cases, SIP is
>> over UDP) but your proposal makes sense.
> 
> Thanks Pascal,
> 
> that explains why nobody spotted this so far.

I think it's more because it's only the heuristic SIP/TCP dissector, instead of the normal SIP/TCP dissector. (Or at least I've never noticed a problem dissecting SIP/TCP, which I do on occasion.)

But yeah your fix looks right.

-hadriel

References:
- [Wireshark-dev] dissect_sip_tcp_heur()
  - From: Martin Kaiser
- Re: [Wireshark-dev] dissect_sip_tcp_heur()
  - From: Pascal Quantin
- Re: [Wireshark-dev] dissect_sip_tcp_heur()
  - From: Martin Kaiser

Prev by Date: Re: [Wireshark-dev] [Wireshark-commits] rev 51301: /trunk/ /trunk/epan/: addr_resolv.c addr_resolv.h /trunk/ui/gtk/: addr_resolution_dlg.c
Next by Date: Re: [Wireshark-dev] [Wireshark-commits] rev 51301: /trunk/ /trunk/epan/: addr_resolv.c addr_resolv.h /trunk/ui/gtk/: addr_resolution_dlg.c
Previous by thread: Re: [Wireshark-dev] dissect_sip_tcp_heur()
Next by thread: Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX-10.5-x86
Index(es):
- Date
- Thread