Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 8995] build fails if system python is

Date Prev · Date Next · Thread Prev · Thread Next
From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Wed, 31 Jul 2013 16:33:10 -0700
On 7/31/13 3:49 PM, bugzilla-daemon@xxxxxxxxxxxxx wrote:
> *Comment # 8
> <https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8995#c8> on bug
> 8995 <https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8995> from Guy
> Harris <mailto:guy@xxxxxxxxxxxx> *
> 
> (In reply to comment #3 <show_bug.cgi?id=8995#c3>)
>> Created attachment 11305 <attachment.cgi?id=11305&action=diff> [details] <attachment.cgi?id=11305&action=edit>
>> Python 2+3 compatibility for make-dissector-reg.py
>> 
>> The attached patch works for Python 2 and 3 on my system. It also makes a
>> couple of changes suggested by "2to3". If no one has any objections I'll
>> check it in.
> 
> Doesn't work on the OS X 10.5 buildbot, though:
> 
>    
> http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/6517/steps/compile/logs/stdio
> 
>     ...
> 
> Traceback (most recent call last):
>   File "../../tools/make-dissector-reg.py", line 288, in <module>
>     new_hash = hashlib.sha1(bytes(reg_code.encode('utf-8'))).hexdigest()
> NameError: name 'bytes' is not defined

This should be fixed in r51079.