Alex Lindberg wrote:
One additional item. When building an NSIS install package on a Win7
64 bit system, the NSIS installs to "C:\Program Files (x86)\NSIS".
In config.nmake, the makensis.exe files uses "C:\Program Files", thus
failing.
I did the following: Added: PROGRAM_FILES_NSIS=%%ProgramFiles(x86)%%
Changed: MAKENSIS="$(PROGRAM_FILES)\NSIS\makensis.exe" To:
MAKENSIS="$(PROGRAM_FILES_NSIS)\NSIS\makensis.exe"
Worked like a charm. I would guess that there are more elegant
solutions to the problem that would detect the path and make the
correct choice. I will leave that to folks smarter than me.
I have made a patch for the Developer Guide to better describe how to
build either 32-bit or 64-bit versions of the code and also made a note
about this issue. I think you must have installed the 64-bit version of
NSIS rather than the 32-bit version 2.46 which is linked to in the
instructions. Can you please check that?
The patch is attached to bug 8386 (see
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8386 ) which also
describes the changes made.
Ed