Wireshark-dev: Re: [Wireshark-dev] Problems in capture_win_ifnames.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Gisle Vanem <gvanem@xxxxxxxxxxxx>
Date: Fri, 23 Nov 2012 14:16:04 +0100
"Guy Harris" <guy@xxxxxxxxxxxx> wrote:


Checked in (with the checks and #defines moved up a little earlier).


Thanks. Works fine now. But I'm curious about why this:

 #if 0 /* XXX: including config.h causes compilation errors; TBD: why */
 #include "config.h"

is needed. "config.h" should be able to live up there. No?

And since the capture_win_ifnames.c code needs WS2, this:
 #include <windows.h>
 #include <winsock2.h>

should be:
 #include <winsock2.h>
 #include <windows.h>

incase someone forgot to add _WIN32_LEAN_AND_MEAN
(which includes <winsock.h> by default).

--gv