Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 46087: /trunk/ /trunk/: capture_opts

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Evan Huus <eapache@xxxxxxxxx>
Date: Mon, 19 Nov 2012 16:08:27 -0500
On Mon, Nov 19, 2012 at 4:00 PM, <morriss@xxxxxxxxxxxxx> wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46087

User: morriss
Date: 2012/11/19 01:00 PM

Log:
 I'm pretty confident the string length will fit in 32 bits; cast away the "possible loss of data" warning on the Win64 build.

Directory: /trunk/
  Changes    Path              Action
  +11 -11    capture_opts.c    Modified

Not that I really think the string is likely to exceed 2^32 characters, but wouldn't it be saner to declare prefix_length as a size_t instead?