Wireshark-dev: [Wireshark-dev] Linear search in value_string_ext

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
Date: Mon, 11 Jun 2012 21:24:11 +0200
Hi,

Bill recently converted lot of code which were using value_string API to 
"newer" value_string_ext API.

But the problem is that not all value_string arrays are sorted for
faster access.

If value_string_ext is used in hfinfo it can be easily found with oneliner:
  $ ./tshark -G values | grep ^E | grep 'Linear Search'

Currently it outputs:
  E       ip.dsfield.dscp 21      dscp_vals       [Linear Search]
  E       rsvp.object     57      rsvp_class_vals [Linear Search]

I've reorder items once in r42418, but I'm not sure if **primary** efford
is to convert all value_string to _ext variant, and remove "old" API,
or to optimize code. Bill?