Wireshark-dev: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item(

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Bill Meier <wmeier@xxxxxxxxxxx>
Date: Thu, 20 Oct 2011 17:55:14 -0400
On 10/4/2011 1:53 PM, Bill Meier wrote:

I propose to use a perl script to automate as much as reasonable the
replacement of TRUE/FALSE in the encoding parameter of the
proto_tree_add_item() calls in dissectors as follows:
OK: Unless there are concerns, there will be one last massive change (at about 3 hours from now, 9 PM EDT). 


Specifically: For the proto_tree_add_item(..., proto_xxx, ...) calls,
use ENC_NA as the encoding arg (since the proto_xxx field type is FT_PROTOCOL). 

On 10/19/2011 7:46 PM, Guy Harris wrote:
>>    FT_PROTOCOL Not yet fixed: Should be ???
>
> ENC_NA.  It's like FT_NONE.

==========

epan/dissectors/*  (non-autogenerated)
    509 files

    203 [[ENC_BIG_ENDIAN]-->[ENC_NA]]
      8 [[ENC_LITTLE_ENDIAN]-->[ENC_NA]]
    508 [[FALSE]-->[ENC_NA]]
     12 [[TRUE]-->[ENC_NA]]


plugins/*
    16 files

     1 [[ENC_BIG_ENDIAN]-->[ENC_NA]]
    16 [[FALSE]-->[ENC_NA]]
     7 [[TRUE]-->[ENC_NA]]

asn1/*
    35 files

     1 [[ENC_BIG_ENDIAN]-->[ENC_NA]]
    48 [[FALSE]-->[ENC_NA]]