Wireshark-dev: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item(

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Bill Meier <wmeier@xxxxxxxxxxx>
Date: Mon, 10 Oct 2011 14:41:59 -0400
On 10/4/2011 2:45 PM, Guy Harris wrote:

Presumably all the uses of
proto_tree_add_item() and the like for FT_ABSOLUTE_TIME values
already have the encoding specified and already use
ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN.



Not quite all :)    See below.


=========================================================================

--> packet-gmhdr.c

   FT_ABSOLUTE_TIME:
proto_tree_add_item(gmhdr_tree, hf_gmhdr_timestamp, tvb, offset, fl, [[FALSE]-->[???]]); 


-->packet-netflow.c

   FT_ABSOLUTE_TIME:
 proto_tree_add_item(pdutree, hf_pie_ntop_rtp_first_ts,
		 tvb, offset, length, [[FALSE]-->[???]]);

   FT_ABSOLUTE_TIME:
 proto_tree_add_item(pdutree, hf_pie_ntop_rtp_last_ts,
			 tvb, offset, length, [[FALSE]-->[???]]);

   FT_ABSOLUTE_TIME:
 proto_tree_add_item(pdutree, hf_pie_plixer_origination_time,
			 tvb, offset, length, [[FALSE]-->[???]]);

   FT_ABSOLUTE_TIME:
 proto_tree_add_item(pdutree, hf_pie_plixer_date_time,
			 tvb, offset, length, [[FALSE]-->[???]]);

-->packet-reload.c

   FT_ABSOLUTE_TIME:
proto_tree_add_item(local_tree, hf_reload_diagnostic_expiration, tvb, offset, 8, [[ENC_TIME_NTP]-->[???]]); 

   FT_ABSOLUTE_TIME:
proto_tree_add_item(local_tree, hf_reload_diagnostic_expiration, tvb, offset, 8, [[ENC_TIME_NTP]-->[???]]); 

   FT_ABSOLUTE_TIME:
proto_tree_add_item(local_tree, hf_reload_diagnosticrequest_timestampinitiated, tvb, offset+local_offset, 8, [[ENC_TIME_NTP]-->[???]]); 

   FT_ABSOLUTE_TIME:
proto_tree_add_item(local_tree, hf_reload_diagnosticresponse_timestampreceived, tvb, offset+local_offset, 8, [[ENC_TIME_NTP]-->[???]]);