Wireshark-dev: Re: [Wireshark-dev] Brutal patch to build with GTK 3.0

From: Anders Broman <a.broman@xxxxxxxxxxxx>
Date: Thu, 18 Aug 2011 18:31:56 +0200
Stephen Fisher skrev 2011-08-18 18:24:
On Thu, Aug 18, 2011 at 03:00:23PM +0200, Anders Broman wrote:

With the enclosed patch Wireshark builds on GTK3.0. Colors are messed
up etc but it should be possible to start to fix things and actually
see what's happening. I wouldn't be surprised if many patches leading
up to this are faulty. Color handling should probably be rewritten to
use GdkRGBA in many places etc.
Thanks!  As long as this doesn't break gtk2 builds, how about we commit
it to allow us all to collaborate on fixes?

Mine still doesn't build (GTK 3.0.12 on FreeBSD 8.2-RELEASE 64-bit)... I
don't set the option for the new UI manager, maybe that's the difference
in yours building and mine?  If we commit your patch, then I can fix
this and commit it.

menus.c: In function 'walk_menu_tree_for_captured_packets':
menus.c:5952: error: 'menu_item_t' has no member named 'children'
menus.c:5975: error: 'menu_item_t' has no member named
'selected_packet_enabled'
menus.c:5976: error: 'menu_item_t' has no member named
'selected_tree_row_enabled'
menus.c:5977: error: 'menu_item_t' has no member named 'enabled'
menus.c:5979: error: 'menu_item_t' has no member named 'enabled'
menus.c:5991: error: 'menu_item_t' has no member named 'children'
menus.c:5997: error: 'menu_item_t' has no member named 'enabled'
menus.c:6010: error: 'menu_item_t' has no member named 'enabled'
menus.c:6013: error: 'menu_item_t' has no member named 'enabled'
menus.c:6014: warning: control reaches end of non-void function
menus.c: In function 'walk_menu_tree_for_selected_packet':
menus.c:6110: error: 'menu_item_t' has no member named 'children'
menus.c:6123: error: 'menu_item_t' has no member named
'selected_packet_enabled'
menus.c:6124: error: 'menu_item_t' has no member named 'enabled'
menus.c:6124: error: 'menu_item_t' has no member named
'selected_packet_enabled'
menus.c:6124: error: 'menu_item_t' has no member named 'callback_data'
menus.c:6136: error: 'menu_item_t' has no member named 'children'
menus.c:6141: error: 'menu_item_t' has no member named 'enabled'
menus.c:6154: error: 'menu_item_t' has no member named 'enabled'
menus.c:6157: error: 'menu_item_t' has no member named 'enabled'
menus.c:6158: warning: control reaches end of non-void function
menus.c: In function 'walk_menu_tree_for_selected_tree_row':
menus.c:6423: error: 'menu_item_t' has no member named 'children'
menus.c:6436: error: 'menu_item_t' has no member named
'selected_tree_row_enabled'
menus.c:6437: error: 'menu_item_t' has no member named 'enabled'
menus.c:6437: error: 'menu_item_t' has no member named
'selected_tree_row_enabled'
menus.c:6437: error: 'menu_item_t' has no member named 'callback_data'
menus.c:6449: error: 'menu_item_t' has no member named 'children'
menus.c:6454: error: 'menu_item_t' has no member named 'enabled'
menus.c:6467: error: 'menu_item_t' has no member named 'enabled'
menus.c:6470: error: 'menu_item_t' has no member named 'enabled'
menus.c:6471: warning: control reaches end of non-void function
menus.c: In function 'rebuild_visible_columns_menu':
menus.c:6820: error: 'main_menu_factory' undeclared (first use in this
function)
menus.c:6820: warning: assignment makes pointer from integer without a
cast
gmake[2]: *** [libui_a-menus.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
mv -f .deps/libui_a-mcast_stream.Tpo .deps/libui_a-mcast_stream.Po
mv -f .deps/libui_a-main_welcome.Tpo .deps/libui_a-main_welcome.Po
mv -f .deps/libui_a-new_packet_list.Tpo .deps/libui_a-new_packet_list.Po
gmake[2]: Leaving directory `/usr/local/src/wireshark-gtk3/gtk'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/local/src/wireshark-gtk3'
gmake: *** [all] Error 2
Hi,
I don't mind if some one commits the patch, but I think you have to build with the new UI MANAGER on GTK 3.0 as there is quite a bit of "factory" stuff left to fix. Unless we want to break the remaining statistics functions until fixed. My GTK 3.0 box is at work so I can't try GTK 3.0 builds until tomorrow.
Regards
Anders

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list<wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe