Wireshark-dev: Re: [Wireshark-dev] [Patch] wsutil/privileges.c

From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Wed, 17 Aug 2011 09:48:38 -0700
Thanks! Checked in in r38583 and scheduled for 1.6.2.

On 8/17/11 8:27 AM, Gisle Vanem wrote:
> init_process_policies() has this:
>  typedef BOOL (*SetProcessDEPPolicyHandler)(DWORD);
> 
> Surely the function must be WINAPI? According to:
>  http://msdn.microsoft.com/en-us/library/bb736299(v=vs.85).aspx
> 
> anyway. So, here is a patch. Besides I've rewritten the assignment and
> if-test:
> 
> --- SVN-Latest\wsutil\privileges.c      Mon Feb 21 19:33:10 2011
> +++ wsutil\privileges.c Wed Aug 17 17:25:16 2011
> @@ -48,7 +48,7 @@
> init_process_policies(void)
> {
>        HMODULE kernel32Handle;
> -       typedef BOOL (*SetProcessDEPPolicyHandler)(DWORD);
> +       typedef BOOL (WINAPI *SetProcessDEPPolicyHandler)(DWORD);
>        SetProcessDEPPolicyHandler PSetProcessDEPPolicy;
> 
> #ifndef PROCESS_DEP_ENABLE
> @@ -70,7 +70,8 @@
>         */
>        kernel32Handle = GetModuleHandle(_T("kernel32.dll"));
>        if (kernel32Handle != NULL) {
> -               if (PSetProcessDEPPolicy = (SetProcessDEPPolicyHandler)
> GetProcAddress(kernel32Handle, "SetProcessDEPPolicy")) {
> +               PSetProcessDEPPolicy = (SetProcessDEPPolicyHandler)
> GetProcAddress(kernel32Handle, "SetProcessDEPPolicy");
> +               if (PSetProcessDEPPolicy) {
>                        PSetProcessDEPPolicy(PROCESS_DEP_ENABLE);
>                }
>        }
> 
> --------
> 
> --gv
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe