Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38340: /trunk/ /trunk/: make-version

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Thu, 4 Aug 2011 23:16:59 +0200
On Thu, Aug 04, 2011 at 08:20:55PM +0000, cmaynard@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38340
> 
> User: cmaynard
> Date: 2011/08/04 01:20 PM
> 
> Log:
>  Don't report svn version if not building from svn.  Change prompted by http://ask.wireshark.org/questions/5376/wireshark-161-title-shows-svn-rev-unknown-from-unknown.
> 
> Directory: /trunk/
>   Changes    Path               Action
>   +3 -2      make-version.pl    Modified

Does this really make sense? How do you differentiate between the "real"
1.6.1 release and a post 1.6.1 source code archive?
I think this particular "fix" is wrong.

Ciao
  Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.