Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38261: /trunk/ /trunk/: configure.in

From: Anders Broman <a.broman@xxxxxxxxxxxx>
Date: Mon, 01 Aug 2011 20:14:30 +0200
Michael T�xen skrev 2011-08-01 18:39:
On Aug 1, 2011, at 6:14 PM, Anders Broman wrote:

Hi,
I found this code in a more recent version of the file
http://buzztard.svn.sourceforge.net/viewvc/buzztard/trunk/buzztard/src/ui/edit/gtkvumeter.c?view=log

#if !GTK_CHECK_VERSION(2,20,0)
#define gtk_widget_set_realized(widget, flag) \
  if (flag) GTK_WIDGET_SET_FLAGS (widget, GTK_REALIZED); \
  else GTK_WIDGET_UNSET_FLAGS (widget, GTK_REALIZED)
#define gtk_widget_get_realized(widget) \
  ((GTK_WIDGET_FLAGS (widget)&  GTK_REALIZED) != 0)
#endif
Hi Anders,

it would make sense to add this to old-gtk-compat.h, but it does NOT resolve
the issue. I still can't compile with GSEAL_ENABLE...

Maybe we need to require a higher version of the gkt library
I'm thinking that we should perhaps only use GSEAL_ENABLE if GTK version is 2.22 or higher as there seems to be quite a few accessors missing. On the other hand gtkvumeter seems to be only used in capture_if_details_dlg.c in case of 802.11 i.e AirPcap I presume. So the whole code could be #ifdeff:ed out
on non Windows with AirPcap.
Regards
Anders

or not
use GSEAL_ENABLE. Not sure. Or come up with better replacements for
gtk_widget_set_realized() and gtk_widget_get_realized().

Best regards
Michael

/Anders
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Michael T�xen
Sent: den 1 augusti 2011 16:39
To: stig@xxxxxxxxxxxxx
Cc: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 38261: /trunk/ /trunk/: configure.in

I'm using gtk 2.18 and when using r38300 I get:
gcc -DHAVE_CONFIG_H -I. -I..  -I.. -I../wiretap    -I/usr/local/include   '-DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.7.0"' -Werror -DINET6 -DGSEAL_ENABLE -DGTK_DISABLE_SINGLE_INCLUDES -no-cpp-precomp -D_U_="__attribute__((unused))" -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign -Wcast-align -Wformat-security -Wold-style-definition -I/usr/local/include -D_REENTRANT -I/usr/X11/include/cairo -I/usr/X11/include/pixman-1 -I/usr/X11/include/freetype2 -I/usr/X11/include -I/usr/X11/include/libpng12 -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include     -MT libui_a-gtkvumeter.o -MD -MP -MF .deps/libui_a-gtkvumeter.Tpo -c -o libui_a-gtkvumeter.o `test -f 'gtkvumeter.c' || echo './'`gtkvumeter.c
gtkvumeter.c: In function 'gtk_vumeter_realize':
gtkvumeter.c:166: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_size_allocate':
gtkvumeter.c:292: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_redraw_timeout':
gtkvumeter.c:668: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_set_orientation':
gtkvumeter.c:761: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_set_scaling':
gtkvumeter.c:984: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_set_scale_items':
gtkvumeter.c:1025: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_set_colors_inverted':
gtkvumeter.c:1236: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_set_yellow_level':
gtkvumeter.c:1268: error: 'GtkObject' has no member named 'flags'
gtkvumeter.c: In function 'gtk_vumeter_set_brightness':
gtkvumeter.c:1300: error: 'GtkObject' has no member named 'flags'

Without your patch I can compile it. So the problem seems to be related to gtk_widget_get_realized() and gtk_widget_set_realized(). Any idea how to fix this?

Best regards
Michael

On Jul 29, 2011, at 7:01 PM, stig@xxxxxxxxxxxxx wrote:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38261

User: stig
Date: 2011/07/29 10:01 AM

Log:
Try build with GSEAL_ENABLE if not gtk3 again.

Directory: /trunk/
Changes    Path            Action
+4 -0      configure.in    Modified

___________________________________________________________________________
Sent via:    Wireshark-commits mailing list<wireshark-commits@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits

mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list<wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list<wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list<wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe