Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 36614: /trunk/ /trunk/epan/dissector

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx>
Date: Wed, 13 Apr 2011 09:48:31 -0600
On Wed, Apr 13, 2011 at 07:57:35AM +0200, Stig Bj�rlykke wrote:
> On Wed, Apr 13, 2011 at 12:12 AM,  <sfisher@xxxxxxxxxxxxx> wrote:
> > Log:
> > �Fix Coverity 1047: UNUSED_VALUE in dissect_smux
> 
> I don't think this is the correct fix, because now the 
> proto_item_add_subtree() has no function. I think maybe smux_tree 
> should be used in dissect_SMUX_PDUs_PDU().

Thanks for pointing that out.  I've reversed my commit and changed the 
dissect_SMUX_PDUs_PDU() call to use smux_tree instead in r36624.