Wireshark-dev: Re: [Wireshark-dev] Wireshark SVN does not build on Ubuntu 64bit (gtk/expert_dlg

From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Tue, 22 Mar 2011 16:27:18 +0100
Hi,
The idea was to get rid of expert_dlg.c and expert_dlg.h so everything needed should go to
expert_comp_dlg.c/expert_comp_dlg.h and anything including expert_dlg.h should be changed to include expert_comp_dlg.h
Instead.
I'm sorry for breaking the build...
Best regards
Anders

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Roland Knall
Sent: den 22 mars 2011 15:51
To: Developer support list for Wireshark
Subject: [Wireshark-dev] Wireshark SVN does not build on Ubuntu 64bit (gtk/expert_dlg.c)

Hello

On my system, Wireshark does not build anymore since revision 36235.
The reason for this is the move of the struct expert_tapdata_s from gtk/expert_dlg.h to gtk/expert_comp_dlg.c .

The stump, which was left on gtk/expert_dlg.h does not work, as gtk/expert_dlg.c needs to use some members of the struct, and cannot do so, as to insufficient declaration for this struct.

Moving the complete struct back to expert_dlg.h and adding a #include to that header in expert_comp_dlg.c solves this issue.

I attached a corrsponding patch, but, am I missing something here?
Should it work?

btw, my system is a fresh setup, everything directly out of the box Ubuntu 10.10 64bit.

kind regards,
Roland
------------------
Tshark -v output:
Compiled (64-bit) with GLib 2.26.1, with libpcap 1.1.1, with libz 1.2.3.4, with POSIX capabilities (Linux), without libpcre, with SMI 0.4.8, with c-ares 1.7.3, with Lua 5.1, with Python, with GnuTLS 2.8.6, with Gcrypt 1.4.5, with MIT Kerberos, with GeoIP.

Running on Linux 2.6.35-28-generic, with libpcap version 1.1.1, with libz 1.2.3.4.

Built using gcc 4.4.5.