Wireshark-dev: Re: [Wireshark-dev] problem with gtk/rtp_player.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx>
Date: Tue, 28 Dec 2010 17:31:21 -0700
On Tue, Dec 28, 2010 at 05:23:45PM -0500, Ed Beroset wrote:

> Under Windows, the recent changes made to gtk/rtp_player.c cause the 
> 2008 version of VC++ to die with a warning that assigning a double to 
> time_t could cause a loss of precision.  I changed it by adding an 
> explicit cast to guint64. This is the old problem with doing math on 
> time -- time_t is an unspecified kind of numerical type.  My Linux box 
> accepts either version.

Thanks.  I've committed SVN revision 35293 which removes the call to 
nstime_to_secs() entirely - since the code only needs one second 
precision as it is, I'm using the secs portion (time_t) of the nstime 
structure directly now.