Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 34796: /trunk/gtk/ /trunk/gtk/: main

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>
Date: Tue, 9 Nov 2010 20:18:46 +0100
On Tue, Nov 09, 2010 at 01:32:09PM +0100, Stig Bj?rlykke wrote:
> On Sat, Nov 6, 2010 at 4:25 PM,  <etxrab@xxxxxxxxxxxxx> wrote:
> > Log:
> > �From Alexander Koeppe:
> > �Patch that fixes overflowing highlighting of data.
> > �https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5374

Btw. should get_byte_view_data_and_length() return tvb_reported_length()?

If yes, I'd vote for checking against 'len' in packet_hex_print():
   if (aend != -1 && (guint)aend > len) aend = len;
   if (bend != -1 && (guint)bend > len) bend = len;