Wireshark-dev: Re: [Wireshark-dev] Is it just me? (build error in packet-q708.c)

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>
Date: Wed, 19 May 2010 16:07:31 +0200
On Wed, May 19, 2010 at 02:56:52PM +0100, Martin Mathieson wrote:
>         { &hf_q708_sanc,
>                 { "Signalling Area Network Code (SANC)","q708.sanc",
> -               FT_UINT16, BASE_DEC | BASE_EXT_STRING,
> VALS(&q708_sanc_areas_ext), 0x0,
> +               FT_UINT16, BASE_DEC | BASE_EXT_STRING,
> VALS(&q708_sanc_areas_ext.vals), 0x0,
>                 NULL, HFILL }
>         },

This patch is wrong, proper way IMHO is to remove VALS() cast, i.e.

> -  FT_UINT16, BASE_DEC | BASE_EXT_STRING, VALS(&q708_sanc_areas_ext), 0x0,
> +  FT_UINT16, BASE_DEC | BASE_EXT_STRING, &q708_sanc_areas_ext, 0x0,

Regards.