Wireshark-dev: Re: [Wireshark-dev] Voip Graph: Port numbers too faint?

From: "RUOFF, LARS (LARS)** CTR **" <lars.ruoff@xxxxxxxxxxxxxxxxxx>
Date: Tue, 4 May 2010 18:20:36 +0200
Thanks for pointing out, Anders.

I also realized that it depends on my WinXP Appearance settings (Display Properties > Appearance > Effects... > Use the following method to smooth edges and fonts). If i disable smoothing, it looks somewhat darker, but still not very readable.
(voip_graph_faint_port_numbers-no-smooth.png) - compare to the first I sent!

I tried to increase the font size by putting
at line 758 in graph_analysis.c:
	pango_font_description_set_size(small_font_desc,(gint)(small_font_size*0.8));

instead of (*0.7) and i'd be happy with that.
(voip_graph_faint_port_numbers-no-smooth-font-size++.png)

But i guess this needs some more validation on other platforms?

Regards,
Lars


-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders Broman
Sent: mardi 4 mai 2010 10:06
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Voip Graph: Port numbers too faint?

Hi,
I think that you could experiment with the values at line 1212 in graph_analysis.c
	/* gray and soft gray colors */
	static GdkColor color_div_line[2] = {
		{0, 0x64ff, 0x64ff, 0x64ff},
		{0, 0x25ff, 0x25ff, 0x25ff}
		/*{0, 0x7fff, 0x7fff, 0x7fff}*/
	};
Regards
Anders 

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of RUOFF, LARS (LARS)** CTR **
Sent: den 3 maj 2010 17:20
To: Developer support list for Wireshark
Subject: [Wireshark-dev] Voip Graph: Port numbers too faint?

Hi folks,

I really like the new pastel color tones of VoIP Graph, but honestly, the port numbers are barely visible now.
(see attached png)
Could they be made a little darker?

Regards,
Lars


----------------
wireshark 1.3.4 (SVN Rev 32342 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.6, with GLib 2.22.4, with WinPcap (version unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with SMI 0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built Mar 31 2010), with AirPcap, with new_packet_list.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.1 (packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch 1_0_rel0b (20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

Attachment: voip_graph_faint_port_numbers-no-smooth.png
Description: voip_graph_faint_port_numbers-no-smooth.png

Attachment: voip_graph_faint_port_numbers-no-smooth-font-size++.png
Description: voip_graph_faint_port_numbers-no-smooth-font-size++.png