Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 32519: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 32519: /trunk/epan/dissectors/ /trun

From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>

Date: Wed, 28 Apr 2010 16:32:35 -0400

guy@xxxxxxxxxxxxx wrote:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=32519

User: guy
Date: 2010/04/19 04:38 PM

Log:
 If that should truly "never happen", use DISSECTOR_ASSERT_NOT_REACHED()
 so it's more clearly marked as a dissector bug.

(It apparently *does* happen - see bug 4698.)

This has the randpkt test failing on the buildbot. Should it really bebackported to 1.2.8?

Or should the randpkt test accept dissector bugs as OK (like the fuzztesting)?

Follow-Ups:
- Re: [Wireshark-dev] [Wireshark-commits] rev 32519: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rsvp.c
  - From: Guy Harris

Prev by Date: Re: [Wireshark-dev] Parsing variable length protocol trailer
Next by Date: Re: [Wireshark-dev] Parsing variable length protocol trailer
Previous by thread: Re: [Wireshark-dev] manual address resolution (Was: [Wireshark-commits] rev 32571: /trunk/ /trunk/epan/: addr_resolv.c addr_resolv.h /trunk/gtk/: CMakeLists.txt Makefile.common help_dlg.c help_dlg.h main.c main.h manual_addr_resolv.c manual_addr_resolv.h menus.c)
Next by thread: Re: [Wireshark-dev] [Wireshark-commits] rev 32519: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rsvp.c
Index(es):
- Date
- Thread