Wireshark-dev: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Wed, 16 Sep 2009 18:58:27 +0200
Hi Lars,

This was changed in response to bug 3773. The 'standard way' of handling windows was changed, but these windows were forgotten. The referenced change corrected that situation. Possibly it has undesired side effects.

I do go back and forth between Calls dialog and Call graph, so several use cases can exist. Re-evaluation of window handling seems in order.

Thanx,
Jaap

RUOFF LARS wrote:
Hi,

i don't know what has been changed exactly, but the VoIP Calls and
-Graph dialog behaviour seems totally screwed up on 1.2.2 on Windows.

Initial condition: Wireshark main window maximized.
Once the Voip Calls and -Graph dialogs are opened:
Click on a line in the Graph dialog.
Now try to navigate to the packet details in main window.
Clicking on the main window doesn't bring it to front.
So minimize the Graph window => minimizes ALL windows!
So it needs an additional step to maximize the main window again.
Navigating back to the Graph dialog is a matter of luck:
Either you clicked on the right one of the two dialog handles that are
shown in minimized state ... or not. If you clicked on the wrong on,
you're back to Calls dialog and need first to click on the dialog to
focus it and then on the Graph dialog to bring it to front.
A nightmare!

To whomever developed VoIP Calls, why do we need to keep the Calls
dialog open once we have opened the Graph dialog? Can't the Graph dialog
not just be made a child to the main window instead? I think this would
fix most issues. And as far as i'm concerned, i nearly never go back to
the Calls list once i have opened the Graph in my every-day buiseness.
What do you think?

I'll have a look at the code later...

regards,
Lars Ruoff


----------------------------------------
Version 1.2.2 (SVN Rev 29910)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and
contributors.
This is free software; see the source for copying conditions. There is
NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

Compiled with GTK+ 2.16.2, with GLib 2.20.3, with WinPcap (version
unknown),
with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI
0.4.8,
with c-ares 1.6.0, with Lua 5.1, with GnuTLS 2.8.1, with Gcrypt 1.4.4,
with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Sep 14 2009), with
AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version
4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS
2.8.1,
Gcrypt 1.4.4, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729