Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 29668: /trunk//trunk/gtk/: new_packe

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Kovarththanan Rajaratnam <kovarththanan.rajaratnam@xxxxxxxxx>
Date: Wed, 02 Sep 2009 21:09:36 +0200
Hey Anders,

Anders Broman wrote:


-----Ursprungligt meddelande-----
Fr�n: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] F�r Joerg Mayer
Skickat: den 2 september 2009 19:44
Till: wireshark-dev@xxxxxxxxxxxxx
�mne: Re: [Wireshark-dev] [Wireshark-commits] rev 29668: /trunk//trunk/gtk/:
new_packet_list.c /trunk/: file.c

On Wed, Sep 02, 2009 at 05:15:25PM +0000, krj@xxxxxxxxxxxxx wrote:

From what I wrote earlier, it seems that the packet list is always updated,
even if nothing changed (new packet comes in but its display is suppressed
due to a display filter). That doesn't sound too efficient either ;-)

 ciao
     Joerg

It's a trade off, the idea being that by keeping the entire list the list
does not have to be recreated at refiltering. With the new packet list the
cost of adding a packet is low.
I think the point Joerg was trying to make is that the packet list view (not the underlying packet list store) is updated even when no packets are added to it. Am I correct Joerg? 

Best regards,
Kovarththanan Rajaratnam