Wireshark-dev: [Wireshark-dev] svn r29431 doesn't look right to me.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: didier <dgautheron@xxxxxxxx>
Date: Sun, 16 Aug 2009 12:00:20 +0200
Hi,
I'm not sure because I don't have EtherCAT captures but

in plugins/ethercat/packet-ecatmb.c for example 
-      FT_UINT8, 16, NULL, 0x0, NULL, 0x0000000F, 0, 0, NULL, NULL }
+      FT_UINT8, 16, NULL, 0x0, NULL, HFILL }

Wasn't 0x0000000F in bitshift field a bug and the right patch something
like?
-      FT_UINT8, 16, NULL, 0x0, NULL, 0x0000000F, 0, 0, NULL, NULL }
+      FT_UINT8, 16, NULL, 0x0F, NULL, HFILL }

Didier