Wireshark-dev: Re: [Wireshark-dev] packet-mpeg-pes.c. compiling fail on win32

From: "Anders Broman" <anders.broman@xxxxxxxxxxxx>
Date: Thu, 30 Apr 2009 11:25:44 +0200
Hi,
If no one beats me to it I'll check this in tonight.
/Anders

-----Original Message-----
From: Jaap Keuter [mailto:jaap.keuter@xxxxxxxxx] 
Sent: den 30 april 2009 09:41
To: Developer support list for Wireshark; Anders Broman
Subject: Re: [Wireshark-dev] packet-mpeg-pes.c. compiling fail on win32

Hi,

This is due to a bug in the sourcecode of the MPEG-PES dissector. It
originates in r26328, which added a bugfix to the generated code with
the use of 'illegal' 
characters in the comment block.
Currently the bugfix is dropped since it was never added to the ASN.1
dissector template, hence has been lost with the new generation of this
code.

Anders, could you:
1. Make the appropriate changes to the dissectors ASN1 template.
2. Remove the illegal quote characters from the comment block.
3. Add the changes to template and generated code to the 1.0.8 roadmap.

Patrick, you can fix this by removing the illegal characters from start
of line
853 and end of line 855 in packet-mpeg-pes.c.

Thanx,
Jaap

Yan, Patrick (NSN - CN/Beijing) wrote:
> 
> Hi all,
> 
> OS is windows XP, wireshark source code is last version of
wireshark-1.0.7.
> 
> Checking for required applications:
>         cl: /cygdrive/c/Program Files/Microsoft Visual Studio
9.0/VC/BIN/cl
>         link: /cygdrive/c/Program Files/Microsoft Visual Studio 
> 9.0/VC/BIN/link
>         nmake: /cygdrive/c/Program Files/Microsoft Visual Studio 
> 9.0/VC/BIN/nmake
>         bash: /usr/bin/bash
>         bison: /usr/bin/bison
>         flex: /usr/bin/flex
>         env: /usr/bin/env
>         grep: /usr/bin/grep
>         /usr/bin/find: /usr/bin/find
>         perl: /usr/bin/perl
>         C:\Python26\python.exe: /cygdrive/c/Python26/python.exe
>         sed: /usr/bin/sed
>         unzip: /usr/bin/unzip
>         wget: /usr/bin/wget
> 
> During compiling, some problem met. Anyone can help to resolve this 
> problem. Thanks.
> 
> Generating Code...
> Compiling...
> packet-h460.c
> packet-h501.c
> packet-inap.c
> packet-ldap.c
> packet-logotypecertextn.c
> packet-mms.c
> packet-mpeg-audio.c
> packet-mpeg-pes.c
> packet-mpeg-pes-template.c(300) : error C2220: warning treated as 
> error
> - no 'ob
> ject' file generated
> packet-mpeg-pes-template.c(300) : warning C4819: The file contains a 
> character t hat cannot be represented in the current code page (936). 
> Save the file in Unico de format to prevent data loss packet-nbap.c 
> packet-ns_cert_exts.c packet-ocsp.c packet-p7.c packet-pcap.c 
> packet-pkcs12.c packet-pkcs1.c packet-pkinit.c packet-pkix1explicit.c 
> packet-pkix1implicit.c packet-pkixproxy.c packet-pkixqualified.c 
> Generating Code...
> Compiling...
> packet-pkixtsp.c
> packet-pres.c
> packet-q932.c
> packet-q932-ros.c
> packet-qsig.c
> packet-ranap.c
> packet-rnsap.c
> packet-ros.c
> packet-rrlp.c
> packet-rtse.c
> packet-s1ap.c
> packet-s4406.c
> packet-sabp.c
> packet-smrse.c
> packet-snmp.c
> packet-spnego.c
> packet-t125.c
> packet-tcap.c
> packet-ulp.c
> packet-wlancertextn.c
> Generating Code...
> Compiling...
> packet-x2ap.c
> packet-x224.c
> packet-x411.c
> packet-x420.c
> packet-x509af.c
> packet-x509ce.c
> packet-x509if.c
> packet-x509sat.c
> packet-dcerpc-nt.c
> Generating Code...
> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 
> 9.0\VC\BIN \cl.EXE"' : return code '0x2'
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 
> 9.0\VC\BIN \nmake.exe"' : return code '0x2'
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 
> 9.0\VC\BIN \nmake.exe"' : return code '0x2'
> Stop.
> 
> Best Regards
> Patrick
> 
> 

Attachment: packet-mpeg-pes-template.c.diff
Description: packet-mpeg-pes-template.c.diff