Wireshark-dev: Re: [Wireshark-dev] Decoding of GSM (G)MM-INFORMATION containing DST IE no longe

From: "Anders Broman" <anders.broman@xxxxxxxxxxxx>
Date: Wed, 18 Mar 2009 15:09:02 +0100
Hi,
This patch should solve it and retain the possibillity to decode APD:s.
Regards
Anders 

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Reinhard
Speyerer
Sent: den 17 mars 2009 22:30
To: Developer support list for Wireshark
Subject: [Wireshark-dev] Decoding of GSM (G)MM-INFORMATION containing
DST IE no longer works in SVN rev 27719

As can be seen from the attached .pcap file (Decode User 0 (DLT=147) as
gsm_a_dtap) decoding of GSM (G)MM-INFORMATION messages containing a
Daylight Saving Time IE which works in Wireshark 1.0.6 no longer works
in SVN rev 27719.

This seems to be caused by the introduction of the two octet length
support for GSM_BSSMAP_APDU_IE in SVN revision 24881 of
packet-gsm_a_common.c as the same IEI 0x49 is also used for the Daylight
Saving Time IE.

The attached patch restores the ability to decode these messages at the
expense of not being able to decode GSM_BSSMAP_APDU_IE with length
between 256 and 511 (which are not currently supported by Wireshark).

Are there better ways to restore the decoding of SM (G)MM-INFORMATION
messages containing a Daylight Saving Time IE?

Regards,
Reinhard

Attachment: gsm_a.patch
Description: gsm_a.patch