It looks suspicious to me but I know nothing about NCP, so perhaps it's
best to file a bug report and then when someone with knowledge of NCP
has a chance to look at it, he can either fix it or close the bug as
invalid if the behavior is correct as is (although if it is ok as is, at
the very least, it might help to include a comment of "intentional
fall-through" to avoid confusion).
- Chris
https://bugs.wireshark.org/bugzilla/
> -----Original Message-----
> From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-
> bounces@xxxxxxxxxxxxx] On Behalf Of Pavol Rusnak
> Sent: Friday, September 05, 2008 9:02 AM
> To: wireshark-dev@xxxxxxxxxxxxx
> Subject: [Wireshark-dev] Question about missing break; in packet-
> ncp22222.inc
>
> Hi all!
>
> I was going through the ncp dissector code and found this (whitespace
> does not match):
>
> 8541 pvalues[2].vflags = request_value->req_nds_flags;
> 8542 pvalues[2].nds_version = request_value->nds_version;
> 8543 pvalues[2].pflags = request_value->req_nds_prot_flags;
> 8544 case 0x04:
> 8545 pvalues[0].vvalue = tvb_get_guint8(tvb, nds_offset);
> 8546 if (pvalues[0].vvalue == 0)
>
> I'd like to ask whether is the missing "break;" intentional or is this
a
> bug. Thanks!
>
> --
> Best Regards / S pozdravom,
>
> Pavol RUSNAK SUSE LINUX, s.r.o
> Package Maintainer Lihovarska 1060/12
> PGP 0xA6917144 19000 Praha 9, CR
> prusnak[at]suse.cz http://www.suse.cz
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> https://wireshark.org/mailman/listinfo/wireshark-dev
CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.