Wireshark-dev: Re: [Wireshark-dev] sip mod

From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Thu, 28 Aug 2008 18:20:37 -0400


Martin Corraine (mcorrain) wrote:
Hello,
I've added two Cisco headers to the SIP dissector. Once I get permission to release my patch I will submit them. But I have one question: do I add my name as one of the authors on the SIP source or is that just for the original authors?

I don't think it's not just for the original authors.

For updates/patches I don't think there's a hard rule but normally I would think the people at the top of the file would be "major" contributors to the dissector (where "major" is not really well defined). Others would go in AUTHORS (for new functionality) and/or the check-in comment (for small changes or bug fixes).