The changes look good to me. I re-ran lint on the updated file (with
some of the warnings taken out just to make it a little bit easier to
scan). There are still a couple of "Possible use of null pointer"
warnings that show up that seem to have merit and might also need some
attention. The first one is:
tcpinfo->seq = msp->seq;
epan\dissectors\packet-tcp.c(1615) : Warning 613: Possible use of null
pointer
'msp' in left argument to operator '->' [Reference: file
epan\dissectors\packet-tcp.c: lines 1482, 1504]
Thanks,
Chris
> -----Original Message-----
> From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-
> bounces@xxxxxxxxxxxxx] On Behalf Of Jaap Keuter
> Sent: Wednesday, August 13, 2008 5:50 PM
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] Lint of packet-tcp.c
>
> Hi,
>
> I've committed revision 26010 with some fixes for the really obvious
> cases.
> Please review the changes, found here:
> http://anonsvn.wireshark.org/viewvc/index.py?view=rev&revision=26010
>
> Most of the lint output is caused by:
> - signed / unsigned differences
> - TRY / CATCH / RETHROW macro
> which could have merit, that is for further study.
>
> Thanx,
> Jaap
>
>
[snip]
CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.
Attachment:
packet-tcp-lint.log
Description: packet-tcp-lint.log