Wireshark-dev: Re: [Wireshark-dev] New proto_add_bits function (Was:rev 21556:/trunk/epan//tr..

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Richard van der Hoff <richardv@xxxxxxxxxxxxx>
Date: Wed, 16 Apr 2008 10:53:23 +0100
Anders Broman wrote:

Hi,
Sounds good to me,

Committed, in revision 25074.


I've been considering if we need
Different proto_tree_add_bits_ret_val()s
for 8 16 32 and 64 bits what do you think?

My main thought is that yet more proto_tree_add_* functions are likely 
to be more confusing than what you gain by allowing different types of 
return_value param. But... YMMV.

Regards

Richard