Wireshark-dev: Re: [Wireshark-dev] Redefining gtk version in uat_gui.c?

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Mon, 07 Apr 2008 10:37:55 +0200
Luis EG Ontanon schrieb:

I probably just copied these from another file (color filters maybe?).
I never noticed this.


On Mon, Apr 7, 2008 at 6:18 AM, Stephen Fisher <stephentfisher@xxxxxxxxx> wrote:

Why does this code at the top of gtk/uat_gui.c redefine
 GTK_MAJOR_VERSION to 1 if it is >= 2??

 if GTK_MAJOR_VERSION >= 2
 # undef GTK_MAJOR_VERSION
 # define GTK_MAJOR_VERSION 1
 # define BUTTON_SIZE_X -1
 # define BUTTON_SIZE_Y -1
 #else
 # define BUTTON_SIZE_X 50
 # define BUTTON_SIZE_Y 20
 #endif

So what to do now?

Remove this hack, the GTK1 code and trying to fix any bugs that shows up?

Regards, ULFL