Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 23873: /trunk/gtk/ /trunk/gtk/: menu

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Mon, 17 Dec 2007 07:23:56 +0100
Hi,

I tried to avoid walking the tree, but failed to spot this issue. Let's see how to treewalk then.

Thanx,
Jaap

Guy Harris wrote:
Stig Bjørlykke wrote:

The hfinfo->strings contains a protocol_t when handling a FT_PROTOCOL, but hfinfo->parent can be -1 in other cases. I suppose all elements created with proto_tree_add_text, which uses the static hf entry in proto.c, will crash wireshark when selected in the Protocol Details.

Yes.

What I think we want is the selected protocol tree item; if it's an FT_PROTOCOL, disable that protocol, otherwise walk up the protocol tree until we find an FT_PROTOCOL, and disable that.