I think it's fine to add the Wake on LAN entries to etypes.h, etc., but
just be aware that 0x0842 is not actually a registered ethertype (*yet*)
with IANA (Refer to: http://www.iana.org/assignments/ethernet-numbers).
0x0842 is only what ether-wake uses for WOL traffic, but technically WOL
is not dependent upon anything but specific byte sequences in the
Ethernet frame's payload - at least in theory. In reality of course, it
makes practical sense to assign a specific ethertype, or udp port
number, or ..., but there are no guarantees. That said, I seriously
doubt that there'll be a conflict with 0x0842 any time soon (as in my
lifetime), but you never know, so I guess it's just something to keep in
mind ...
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Stephen Fisher
Sent: Tuesday, November 06, 2007 12:33 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New dissector proposed: WakeOnLAN
On Tue, Oct 30, 2007 at 02:12:10PM -0400, Maynard, Chris wrote:
> I'm submitting a new dissector for consideration in being included
> with Wireshark. It is for the WakeOnLAN. I compiled and tested it on
> both Windows XP and Fedora Core 6 running Linux 2.6.11-1.1369_FC4.
I have committed your new dissector as SVN revision 23371. I added
entries to epan/etypes.h and epan/dissectors/packet-ethertype.c for Wake
on LAN and used the #define from the first file instead of 0x0842 in the
actual dissector file. The visible part of these changes allows the
Ethertype to show a value of "Wake on LAN" in the Ethernet dissector.
Thanks for your contribution! I meant to make a Wake on LAN dissector a
while back, but never got around to it :).
> I added a wiki page for it already and included a sample capture file
> as well (See http://wiki.wireshark.org/WakeOnLAN).
Looks great. Thanks!
Steve
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
-----------------------------------------
This email may contain confidential and privileged material for the
sole use of the intended recipient(s). Any review, use, retention,
distribution or disclosure by others is strictly prohibited. If you
are not the intended recipient (or authorized to receive for the
recipient), please contact the sender by reply email and delete all
copies of this message. Also, email is susceptible to data
corruption, interception, tampering, unauthorized amendment and
viruses. We only send and receive emails on the basis that we are
not liable for any such corruption, interception, tampering,
amendment or viruses or any consequence thereof.