Wireshark-dev: [Wireshark-dev] Opinions on new feature needed

From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Mon, 5 Nov 2007 18:34:25 -0700
I have a new feature ready to commit and I need some opinions on whether
it should be enabled or disabled by default.  I have a layout
preferences option to enable/disable it.

The feature is a drop-down arrow on the right side of the main toolbar
that lets you access any buttons that don't fit on the screen/in the
Wireshark main window.  The advantage to enabling it by default is that
users will find out about it quicker.  The disadvantage to enabling it
by default is that it takes the place of the rightmost button, which may
annoy users that use it frequently (of course, they can just disable it
in the layout preferences if they know that you can disable it:).

More details/caveats: I had to implement the new GTK 2.4+ toolbar API to
enable this feature.  I duplicated some of the macros in gtk/toolbar.c
to make a GTK1/2 version and a GTK2.4+ version.  Everything works the
same as before and it is still GTK1/2 (<2.4) compatible.  However, the
drop-down menu under the arrow does not obey the text only option for
the toolbar nor does it support icon images on the toggle buttons
(colorize packet list & auto scroll packet list) - it just shows a check
mark and the label.


Thanks for your response.

Steve