Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1903] wimaxasncp: TLVsdefined in XML f

From: "Anders Broman" <a.broman@xxxxxxxxx>
Date: Thu, 11 Oct 2007 19:25:39 +0200

If it’s going to be built in can’t it have it’s own directory together with Diameter, Radius etc so we don’t have to move it later?

Regards

Anders

 


Från: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Martin Mathieson
Skickat: den 11 oktober 2007 19:15
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1903] wimaxasncp: TLVsdefined in XML files

 

 

On 10/11/07, bugzilla-daemon@xxxxxxxxxxxxx <bugzilla-daemon@xxxxxxxxxxxxx > wrote:

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1903


------- Comment #11 from martin.r.mathieson@xxxxxxxxxxxxxx  2007-10-11 09:34 GMT -------
Just to be clear - I was thinking of people having the flexibility to offer the
very latest plugin code (taken from the main svn repo) with a stable release of
Wireshark (perhaps supplied by their distro).

Rather than people distributing private modifications of the plugin.

Anyway, the updated plugin has had some more testing. Can we decide now where
the XML file should be installed (I don't think this patch changed
wireshark.nsi...) ?


Any ideas what to do  with this?  The patched version seems to work equivalently to the current version that doesn't use XML for the TLVs.  The immediate issue seems to be where the XML should be installed. It is currently written (during a 'make install' to the data direction, e.g. on my machine here /usr/local/share/wireshark/plugins/wimaxasncp).  Should it instead go in the plugins folder with the plugin itself?  I couldn't find any other precedents for plugins installing extra files.  Does this seem to be acceptable? If so, I'll add the entry needed to wireshark.nsi and check it in tomorrow.

I don't think anyone disagrees that it can become a built-in dissector once it and the WiMAX standard matures a bit more.

Regards,
Martin