Title: Dissectors for SMS over GPRS-LLC
Hi
SMS msg can be carried over packet switched GPRS, and I am trying to have Wireshark decode SMS carried on GPRS LLC protocol (SAPI 7).
The stack is the following:
-------------------
| sms msg |
-------------------
| sms T-PDU | --> dissector exists (gsm_sms) in packet-gsm_sms.c
-------------------
| sms RP | --> dissector exists (gsm_a_rp) in packet-gsm_a.c
-------------------
| sms CP |
-------------------
| GPRS LLC | --> dissector exists (gprs-llc) in packet-gprs-llc.c
-------------------
some SMS Control Protocol (SMS CP) fields are included in GSM A DTAP dissector, but not the whole protocol.
So I basically wrote a small plugin for SMS CP -following the dev guidelines-, and linked to GPRS-LLC and SMS-RP and it works fine.
The questions are:
- is there any interest in having this submitted back to the Wireshark source ?
- if it is the case, what is the best practice (plugin, native) and recommendations for the dissector calls - restrain the calls to be within the new protocol code, or rather use call_dissector() etc in other dissectors, which implies a small diff on other dissectors too.
Thks, and btw I found the developper doc extremely useful -many thks to the author(s).
Cyrille