Wireshark-dev: Re: [Wireshark-dev] [PATCH] wiretap: Add MPEG PES.

From: "Mauro Mincarelli" <mauro.mincarelli@xxxxxxxxx>
Date: Mon, 6 Aug 2007 11:54:42 +0200
Sorry but I don't understand the effect of your patch: I've applied your patch but I still don't see any MPEG PES decoding (see attachment). I only see the payload of the TS packet but its content (PES packet or PSI table info) is shown only in hex format and no further info is provided on upper layers (PES and PSI).
Is there any way to show also  PES and PSI decoding over MPEG2TS ?

thanks

Mauro


On 8/5/07, Shaun Jackman < sjackman@xxxxxxxxx> wrote:
This patch adds MPEG PES (packetized elementary stream) to the list of
magic types in wiretap/mpeg.c.

Cheers,
Shaun

2007-08-05  Shaun Jackman  <sjackman@xxxxxxxxx>

        * wiretap/mpeg.c (magic): Add MPEG PES.

Index: wiretap/mpeg.c
===================================================================
--- wiretap/mpeg.c      (revision 22456)
+++ wiretap/mpeg.c      (working copy)
@@ -247,14 +247,15 @@
        g_free(wth-> capture.mpeg);
}

-/* XXX We probably need more magic to open more types */
struct _mpeg_magic {
        size_t len;
        const gchar* match;
} magic[] = {
-       {3,"TAG"},
-       {3,"ID3"},
-       {0,NULL}
+       { 3, "TAG" }, /* ID3v1 */
+       { 3, "ID3" }, /* ID3v2 */
+       { 3, "\0\0\1" }, /* MPEG PES */
+       /* XXX MPEG audio is missing. */
+       { 0, NULL }
};

int

_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev



Attachment: Screenshot-tmt_multicast_mpeg2TS.pcap - Wireshark.png
Description: PNG image