-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jeff Morriss wrote:
> Marc Petit-Huguenin wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>>
>> Please find attached a new version of the patch.
>
> Checked in (rev 22383), thanks!
>
> BTW, this dissector really should be broken up into multiple functions
> or something. I reindented it a bit, but the main function really is
> too big.
OK, I'll fix that in the next version.
>
> A more generic question is: how are dissectors using tcp_dissect_pdus()
> supposed to be "new style" (this dissector is now effectively no longer
> "new style"). "packet-xot" takes one approach but it's not obvious to
> me if that will really work well: it requires the dissector to be given
> (at least) the PDU header length in the first call.
I am not sure to understand what you suggest I should do.
Thanks.
- --
Marc Petit-Huguenin [ ]
Home: marc@xxxxxxxxxxxxxxxxxx [RFC1855-compliant space for rent ]
Work: marc@xxxxxxx [ ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGpQXE9RoMZyVa61cRAiQdAKCijCbrArmsniF35vAMSWZvfWLCKQCghm5p
g2lLT9Fldj5GgL/ChrJpDhE=
=JgaH
-----END PGP SIGNATURE-----