Wireshark-dev: Re: [Wireshark-dev] [PATCH] BACnet bacapp fixes for bug 1670

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Sat, 07 Jul 2007 00:38:41 +0200
Hi,

Checked in revision 22262 and closed bug 1670.

Thanx,
Jaap

Steve Karg wrote:

Hello Developers,

Attached is a patch that fixes bug 1670 and related issues.

For the BACnet GetEventInformation-ACK request dissector:
1. Corrected BitString decoding for acknowledgedTransitions and eventEnable.

2. Corrected the ability to decode more than one event.

3. Grouped each item of the sequence using subtrees.  Added more informative
text to Priority and Timestamp.

4. Corrected eventState to use BACnetEventState enumeration instead of
BACnetEventStateFilter.

I validated the results with the capture attached to the bug report.  I also
fuzz tested for awhile with my captures with no failures.

Best Regards,

Steve