Wireshark-dev: Re: [Wireshark-dev] [PATCH] MySQL decode OK-Packet improvement

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Mon, 18 Jun 2007 12:00:18 -0700
On Sun, Jun 10, 2007 at 07:16:29PM +0100, Martin Warnes wrote:

> Currently the MySQL dissector assumes that an OK-Packet Response 
> contains the Server_Status field. Having checked the MySQL protocol 
> page I can't say conclusively whether it should or it shouldn't, 
> however I've come across a couple of MySQL Java clients that receive 
> the OK-Packet without the Server_Status field set in response to a 
> "SET AUTOCOMMIT" call.
> 
> The attached patched simply adds a check to ensure the Server_Status 
> field is present before calling function mysql_dissect_server_status.

Thanks for your contribution!  I have checked in this patch as SVN 
revision 22129.

P.S. Would you like your e-mail address in the AUTHORS file updated from 
martin.warnes [AT] ntlworld.com to martin [AT] warnes.homeip.net ?


Steve