Wireshark-dev: Re: [Wireshark-dev] [PATCH] Added options declared in DSLForum TR-111 to STUN de

Date Prev · Date Next · Thread Prev · Thread Next
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Thu, 31 May 2007 16:55:23 -0700
On Tue, May 29, 2007 at 02:50:03PM -0400, Zach Chadwick wrote:

> TR-111, from the DSL-Forum adds two options to STUN (RFC 3489) to help 
> with TR-069 enabled devices traverse firewalls. TR-111 can be read 
> here: http://www.dslforum.org/techwork/tr/*TR-111*.pdf
> 
> This patch adds support for decoding the two optional STUN attributes 
> used by TR-111.  One is simply a zero-length attribute, and the other 
> a string attribute.
> 
> Also attached is an example .cap file containing a STUN packet with 
> these options.  The .diff was generated from the top of the svn tree, 
> the file modified was ./epan/dissectors/packet-stun.c (revision 21922)

Thanks for your patch and capture file!  I have committed your patch as 
SVN revision 22019 with a minor change.  I changed 
stun.att.connection.request.binding to 
stun.att.connection_request_binding to be like most of the other 
dissectors (each dot seperates something into groups, there is a group 
of stun.* variables and a group of stun.att.* variables, but no other 
stun.att.connection.* variables, etc.)


Steve