Wireshark-dev: Re: [Wireshark-dev] [PATCH] Fix compilation failures on x86_64-unknown-linux-gnu

From: Jeff Morriss <jeff.morriss@xxxxxxxxxxx>
Date: Tue, 29 May 2007 16:39:37 +0800


Guy Harris wrote:
Jeff Morriss wrote:
Problem is that how you print 64-bit numbers varies. %llu doesn't always work

...and neither does "long long" as a data type.

(for example the Windoze buildbot is now red). Instead the PRI*64 macros should be used.

Or the G_GINT64_MODIFIER macro. I seem to remember that there was an issue a while ago where the native *printf on Windows used %I64[doxu] but the Windows GLib *printf routines used %ll[doxu], or something such as that (because it had its own formatting routine). As such, I checked in a change to check for G_GINT64_MODIFIER in the top-level configure script (as is done in the Wiretap configure script), and to use that when printing gint64/guint64 values, rather than casting to "long long" or "unsigned long long".

You mean rather than using %lld or %llu?

Should the PRI*64 macros (which I just recently started adding--meaning there were some there before, it's just that only recently did /I/ add some) be replaced with G_GINT64_MODIFIER?