jmayer@xxxxxxxxxxxxx wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21865
User: jmayer
Date: 2007/05/21 07:43 PM
Log:
put fwrite and fread into DISSECTOR_ASSERT in order to use the result
Is it a good idea to put "productive" code into an DISSECTOR_ASSERT?
At least the ANSI C assert() won't call any comparison code at all in a
release version.
Without looking deeply into the code: This seems to be a problem which
could possibly happen - and therefore should better be handled by
returning an error code IMHO.
However, at least it's a bit better than before ;-)
Regards, ULFL