Bill Meier wrote:
List:
Wireshark has a number of "Save .... before ... ?" dialogs.
One has "Yes/No/Cancel" buttons; Most have "Save/Continue/Cancel" buttons;
One has "OK/Cancel" buttons..
I propose to have these dialogs all use "Yes/No/Cancel"
buttons since I think this would be more intuitive.
If there are no concerns or other suggestions, I'll commit the change
in a day or so.
Bill
---------------------------------------------------------------------------
Save/Continue/Cancel
main.c: "Save capture file before program quit?"
capture_dlg.c: "Save capture file before starting a new capture?"
capture_file_dlg.c: "Save capture file before opening a new one?"
capture_file_dlg.c: "Save capture file before closing it?"
drag_and_drop.c: "Save capture file before opening a new one?"
airpcap_dlg.c: "Save settings before closing?"
"... before closing" what will be closed? A file, the program? -> that's
a very generic term "before program quit" might be better here - if
that's what will happen :-)
airpcap_dlg.c: "Save settings before changing interface?"
OK/Cancel
capture_file_dlg.c: "Save the capture file before merging to another one?"
Yes/No/Cancel
menu.c: "Save capture file before opening a new one?"
First of all, thanks for putting this together!
I agree that this should be more consistent, but please don't do this
change in the way you've mentioned, it's against human interface guidelines!
HIG tells you that the action should be on the button - it makes it much
faster to handle. People tend to scan the button texts first, so they
should give you an idea what will happen.
At least use the Save/Continue/Cancel combination here, as it's a lot
better than Yes/No/Cancel.
There's already a bug report, that even the Save/Continue/Cancel is not
the right text for the program quit question, see
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1427.
Regards, ULFL