Wireshark-dev: Re: [Wireshark-dev] [Patch] pragma warning

From: Gisle Vanem <gvanem@xxxxxxxxxxxx>
Date: Wed, 28 Mar 2007 05:36:06 +0200
"Ulf Lamping" <ulf.lamping@xxxxxx> wrote:

If you still have such problems, please note.

There's still some in generated files. It seems someone added the pragmas after they where autogenerated. IMHO the #pragma should go elsewhere. But
where, should be left to the experts.

A patch for now:

diff -u3 -Hb -r SVN-Latest\epan\dissectors\packet-dcerpc-dfs.c .\epan\dissectors\packet-dcerpc-dfs.c
--- SVN-Latest\epan\dissectors\packet-dcerpc-dfs.c Tue Mar 27 17:18:50 2007
+++ .\epan\dissectors\packet-dcerpc-dfs.c Tue Mar 27 17:44:53 2007
@@ -22,7 +22,7 @@
#include "packet-windows-common.h"
#include "packet-dcerpc-dfs.h"

-#ifdef _WIN32
+#ifdef _MSC_VER
/* disable: warning C4101: 'xy' : unreferenced local variable */
#pragma warning(disable:4101)
#endif
diff -u3 -Hb -r SVN-Latest\epan\dissectors\packet-dcerpc-eventlog.c .\epan\dissectors\packet-dcerpc-eventlog.c
--- SVN-Latest\epan\dissectors\packet-dcerpc-eventlog.c Tue Mar 27 17:18:52 2007
+++ .\epan\dissectors\packet-dcerpc-eventlog.c Tue Mar 27 17:45:04 2007
@@ -22,7 +22,7 @@
#include "packet-windows-common.h"
#include "packet-dcerpc-eventlog.h"

-#ifdef _WIN32
+#ifdef _MSC_VER
/* disable: warning C4018: '<' : signed/unsigned mismatch */
#pragma warning(disable:4018)
#endif

diff -u3 -Hb -r SVN-Latest\plugins\giop\packet-cosnaming.c .\plugins\giop\packet-cosnaming.c
--- SVN-Latest\plugins\giop\packet-cosnaming.c Tue Mar 27 17:18:48 2007
+++ .\plugins\giop\packet-cosnaming.c Wed Mar 28 05:20:33 2007
@@ -48,7 +48,7 @@
G_MODULE_EXPORT const gchar version[] = "0.0.1";
#endif

-#ifdef _WIN32
+#ifdef _MSC_VER
/* disable warning: "unreference local variable" */
#pragma warning(disable:4101)
#endif

And for airpcap.h:

diff -u3 -Hb -r SVN-Latest\airpcap.h .\airpcap.h
--- SVN-Latest\airpcap.h Tue Jan 02 23:26:52 2007
+++ .\airpcap.h Wed Mar 28 03:49:39 2007
@@ -24,8 +24,10 @@

#include <epan/crypt/wep-wpadefs.h>  /* WEP_KEY_MAX_SIZE */

+#ifdef _MSC_VER
/* This disables a VS warning for zero-sized arrays. All the compilers we support have that feature */
#pragma warning( disable : 4200)
+#endif

#ifdef __cplusplus
extern "C" {

---------------
--gv