Committed revision 20888.
Without the makefile changes to build the test program as
I can't test it on Windows.
Best regards
Anders
-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Richard van der Hoff
Skickat: den 15 februari 2007 22:36
Till: Developer support list for Wireshark
Ämne: [Wireshark-dev] reassembly.c: fragment_set_partial_reassembly()
forfragment_add_seq
Hi guys,
I've been working on support for reassembly of protocols over RTP; for
this I needed to be able to do fragment_set_partial_reassembly() on
fragments added with fragment_add_seq().
Here are a bunch of patches... I'd be much obliged if they could be
reviewed and hopefully committed; there will be a bunch of other patches
to follow soon!
Cheers,
Richard
01_reassemble_test.patch
------------------------
I didn't want to do anything without some unit tests, so here they are.
This allows a standalone binary, epan/reassemble_test, to be built; this
can be run from the commandline and should end up printing out "success"
if all goes well.
Incidentally: is it possible to get the buildbot to run things like
this, exntest and tvbtest?
02_reassemble_refactor.patch
----------------------------
fragment_add_seq, fragment_add_dcerpc_dg and fragment_add_seq_check_work
were all pretty much carbon-copies of each other. This patch factors out
the common parts of the routines into a new routine,
fragment_add_seq_key().
03_reassemble_partial_reassembly.patch
---------------------------------------
This makes fragment_set_partial_reassembly() work for datagrams
assembled with fragment_add_seq(). The patch itself is actually quite
small, but it adds another unit test which is reasonably lengthy.