Wireshark-dev: Re: [Wireshark-dev] [Patch] packet-kerberos.c

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Tue, 16 Jan 2007 20:31:21 +0100 (CET)
Hi,

Implemented the suggestion, with slight modification.
Moved glib.h inclusion up i.s.o. crypt-md5.h down because you've omitted
the conditional.

For easier handling could you attach the patches to the emails i.s.o.
pasting them?

Thanx,
Jaap

On Tue, 16 Jan 2007, Gisle Vanem wrote:

> * <epan/crypt/crypt-md5.h> must come after <glib.h> because of
>   'guint8' etc.
>
> * Include <wiretap/file_util.h> because of eth_fopen().
>
> --- SVN-Latest\epan\dissectors\packet-kerberos.c        Wed Jan 03 17:26:35 2007
> +++ epan\dissectors\packet-kerberos.c   Tue Jan 16 12:44:55 2007
> @@ -71,12 +71,12 @@
>  #include <nettle/des.h>
>  #include <nettle/cbc.h>
>  #endif
> -#include <epan/crypt/crypt-md5.h>
>  #include <sys/stat.h>  /* For keyfile manipulation */
>  #endif
>
>  #include <glib.h>
>
> +#include <epan/crypt/crypt-md5.h>
>  #include <epan/packet.h>
>
>  #include <epan/strutil.h>
> @@ -96,6 +96,8 @@
>  #include <epan/dissectors/packet-dcerpc.h>
>
>  #include <epan/dissectors/packet-gssapi.h>
> +
> +#include <wiretap/file_util.h>
>
>  #define UDP_PORT_KERBEROS              88
>  #define TCP_PORT_KERBEROS              88
>
>
> --------------
>
> PS. What's up with the mailing-list software? Every message looks like
> crap; all line-endings are missing. Is the ML-software running on a Mac?
>
> --gv
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
>