Wireshark-dev: Re: [Wireshark-dev] [PATCH] New plugin for Homeplug

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Tue, 5 Dec 2006 00:20:44 +0100 (CET)
Hi,

I've looked at the code. Some things you can improve on.
1. Get rid of the C++ style comments
2. Make it into a regular dissector, getting rid of all the plugin
wiring.
3. Add the ether type to etypes.h i.s.o. defining it yourself.

BTW: It's such a simple protocol you could consider using ptvcursor.

Thanks,
Jaap


On Mon, 4 Dec 2006, Sebastien Tandel wrote:

> Hi,
>
>     Here is a patch for the plugin supporting the dissection of the
> intellon homeplug powerline protocol based on INT51X1 specification.
>
> Sebastien Tandel
>