Wireshark-dev: Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars

From: Guy Harris <guy@xxxxxxxxxxxx>

Date: Thu, 23 Nov 2006 13:46:53 -0800

Stefan (metze) Metzmacher wrote:

if isprint() is used, we should make sure the value
isn't larger than 0xFF, as currently GDK_Up and GDK_Down
trigger a focus switch to the filter.


Should it be

	if (isascii(event->keyval) && isprint(event->keyval))

so that control characters don't get intercepted, either?

Follow-Ups:
- Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
  - From: Gerald Combs

References:
- [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
  - From: Stefan (metze) Metzmacher

Prev by Date: Re: [Wireshark-dev] [Wireshark Plugin] Accentued Characters
Next by Date: Re: [Wireshark-dev] [PATCH] fix SMB_NETLOGON cmd 0x17,0x19
Previous by thread: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
Next by thread: Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
Index(es):
- Date
- Thread