Hi,
Can you try avoiding functions that allocate memory that has to be freed?
We have ephemeral memory allocators for this purpose.
I.e. tvb_get_ephemeral_string instead of tvb_get_string+gfree
There are some // comments in the source. Please replace with C comments
Can you also provide a few small example captures to test with and a nice page on the WIKI for this protocol?
Apart from that it looks good at a first glance.
On 10/25/06, Bill Florac <bill.florac@xxxxxxxxxxxxxx> wrote:
Developers,
Please consider adding the attached source code for dissecting the "Architecture for Control Networks", or "ACN" to the Wireshark build. We have done a fair amount of internal testing and there a no known bugs. I think we complied with all the source code format requirement but if not, just let me know and I will gladly fix them. Once posted, I will also submit capture files samples.
It was last tested on build 19109. It was tested as both a built in dissector and as a plug-in. As requested (by Jaap) I am only submitting the files for a built-in variant. There is an existing ACN plug-in that should be removed.
Dissector also includes an option to enable an extension protocol called Streaming DMX (ANSI BSR E1.31). This extension has not been formally approved by ANSI yet and is subject to change..
<<packet-acn.c>> <<packet-acn.h>>
Bill Florac
Senior Technical Product Specialist
bill.florac@xxxxxxxxxxxxxx
Electronic Theatre Controls, Inc.
3031 Pleasant View Rd .
Middleton, WI 53562
608-831-4116 (corp. phone)
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev