While researching another bug in follow_dlg.c, I spotted a different one
that causes the from and to hostnames/ip addresses to be the same in the
follow tcp stream dialog only with IPv6. Please apply attached patch
that corrects the code as shown below:
if (stats.is_ipv6) {
struct e_in6_addr ipaddr;
memcpy(&ipaddr, stats.ip_address[0], 16);
hostname0 = get_hostname6(&ipaddr);
memcpy(&ipaddr, stats.ip_address[0], 16); <- should should be [1]
hostname1 = get_hostname6(&ipaddr);
} else {
guint32 ipaddr;
memcpy(&ipaddr, stats.ip_address[0], 4);
hostname0 = get_hostname(ipaddr);
memcpy(&ipaddr, stats.ip_address[1], 4);
hostname1 = get_hostname(ipaddr);
Thanks,
Steve
Index: gtk/follow_dlg.c
===================================================================
--- gtk/follow_dlg.c (revision 19580)
+++ gtk/follow_dlg.c (working copy)
@@ -332,7 +332,7 @@
struct e_in6_addr ipaddr;
memcpy(&ipaddr, stats.ip_address[0], 16);
hostname0 = get_hostname6(&ipaddr);
- memcpy(&ipaddr, stats.ip_address[0], 16);
+ memcpy(&ipaddr, stats.ip_address[1], 16);
hostname1 = get_hostname6(&ipaddr);
} else {
guint32 ipaddr;